Scott Todd

Results 405 comments of Scott Todd

I think I see enough of the pieces now to refactor the code a bit and add some helpful warnings and documentation. I'm not sure how I'll test my changes...

That could work, yeah. When I say "test my changes" here, I'm still just referring to local development "testing", not automated CI testing - that would be a nice bonus.

Pushed an initial attempt at reworking how the target init is handled: https://github.com/iree-org/iree/pull/18587 . I could pass that off to someone else and context switch to other tasks 🤔

> I'm not sure why `Ninja` handle dependencies correctly, while `make` doesn't. In some cases Ninja just gets lucky. The `missingdeps` feature in Ninja can help spot some dependency graph...

FYI Ninja 1.13.0 is affected by https://github.com/ninja-build/ninja/issues/2616 which breaks various builds on Windows. I've had to unpin ninja in a few repositories to avoid the broken release and it looks...

> WDYT @benvanik @stellaraccident @ScottTodd ? nit about GitHub: Please put tags like these in comments, not commit messages (or PR descriptions that then become commit messages). If someone pushes...

> I have followed your suggestion to drop `TARGET_CPU` and `TARGET_CPU_FEATURES`. While doing do, I found the place which had originally motivated them: this is where we pass a `--requirements`...

(GitHub has a few ways to view diffs between commits, but force pushing with a rebase defeats most of them) * Changes since last review shows no diff ![image](https://github.com/user-attachments/assets/61dcecc6-70be-4db1-a255-7ffdfae08fc8) *...

> @ScottTodd , for my education - when my PR has a conflict with `main`, so I have to rebase it, that in itself seems to require a force-push, right...

Build failures on MSVC: https://github.com/iree-org/iree/actions/runs/11401187470/job/31723569010#step:7:7793 > @stellaraccident , i'm blissfully unaware of release schedules. If there is any upcoming release, this one is worth having on it. See the pinned...