Scott Todd comments

Results 405 comments of


                                            Scott Todd

Running benchmarks is blocked by build_all

I think we should move the benchmark jobs moved out of ci.yml (I initially pushed for them to not start there in the first place... but that's the current reality)....

Running benchmarks is blocked by build_all

Pushed two test PRs with different approaches. Seeing if either works and is worth pursuing further. 1. Split ci.yml into ci.yml and benchmark.yml (probably good long term, but duplicates some...

Running benchmarks is blocked by build_all

I think this is solved well enough for now by https://github.com/iree-org/iree/pull/17400. The build system setup and github actions workflows could use more refactoring to support packages instead of the install...

dynamic_gather does not support properties on Windows

This shouldn't be operating system specific. I suspect you have a different version of `iree-compile` _or_ JAX on Linux. (If we switch IREE and its deps to use VHLO instead...

Failed to legalize torch.operator "onnx.Expand"

We have two tests (from the upstream ONNX test suite) for `onnx.Expand`: * https://github.com/nod-ai/SHARK-TestSuite/blob/main/iree_tests/onnx/node/generated/test_expand_dim_changed/model.mlir * https://github.com/nod-ai/SHARK-TestSuite/blob/main/iree_tests/onnx/node/generated/test_expand_dim_unchanged/model.mlir Both are passing on all in-tree backends. If that specific op is the problem,...

can't build on Mac Sequoia 15.4

Can you share more context around the error message? Ideally full output from the `build_all.sh` script (or all CMake configure + build output).

Can ConvertAten_IndexPutImplOp pattern handle the scene that indices is bool?

I'm seeing a similar failure, filed https://github.com/llvm/torch-mlir/issues/3433 with some other details.

Runtime stuck on execution of inference of YOLOv5 compiled from ONNX

Sounds like https://github.com/iree-org/iree/issues/16666 is showing up outside of the individual op tests. Not sure, needs further debugging through the stack.

Fix CMAKE_INSTALL_PREFIX init behavior on Win32.

Thanks for approving! Should I merge this myself with squash and merge, or do you want to do that yourself? https://github.com/ROCm/hipFFT/blob/develop/.github/CONTRIBUTING.md#process

[tosa] failed to legalize operation 'arith.extsi'

Oof. Mobilenet regression is not good. We're lacking test coverage for TOSA / TFLite (https://github.com/iree-org/iree-test-suites/issues/5) Commit range: https://github.com/iree-org/iree/compare/iree-3.1.0rc20241205...iree-3.1.0rc20241206 . The PR that Ian linked is likely the culprit, coming in...