Scott Todd
Scott Todd
> `git add . --renormalize` fixes line ending stuff for me whenever I have issues - maybe could run that after > > (git line ending handling confuses me, so...
Started looking at mypy on https://github.com/ScottTodd/iree/tree/pre-commit-mypy Will need to either fix some issues or figure out how to limit how much of the repo it looks at ``` D:\dev\projects\iree (pre-commit-mypy)...
The git hook works, even via `git gui`: 
Most of the hooks are fast and only run on individual files when relevant. The slowest right now appears to be bazel_to_cmake, taking several seconds. I just set bazel_to_cmake to...
Got a few devs specifically request getting the buildifier check running seamlessly (all platforms, ideally no manual download) [here on Discord](https://discord.com/channels/689900678990135345/690274711523164166/1247921151154458635). Can also check if there is an automatic deps...
Classic... there are two hooks for running buildifier listed at https://pre-commit.com/hooks.html, both of which assume that buildifier is already installed (despite pre-commit being a package manager), then https://github.com/bazelbuild/buildtools itself uses...
Except for one last change (https://github.com/iree-org/iree/pull/17619) and pytype (which will be replaced with mypy), this migration is complete 🥳
All done! (except for setting up mypy for python type checking)
I see some matmul test failures on arm64 (only tested on postsubmit by default, opt-in on presubmit) that started after this was merged: https://github.com/iree-org/iree/actions/runs/9273840024/job/25514820313#step:5:2008 ``` --- TEST[matmul_accumulate_DYNxDYNxbf16_times_DYNxDYNxbf16_into_DYNxDYNxf32_6_13_3_acc_12] --- Matmul shape...
Also Android test failure: https://github.com/iree-org/iree/actions/runs/9273840024/job/25515648799#step:6:579 ``` + adb shell 'cd /data/local/tmp && LD_LIBRARY_PATH=/data/local/tmp TEST_TMPDIR=/data/local/tmp/iree/tests/e2e/linalg/check_llvm-cpu_local-task_narrow_n_matmuls.mlir/test_tmpdir /data/local/tmp/iree/tests/e2e/linalg/check_llvm-cpu_local-task_narrow_n_matmuls.mlir/iree-check-module --module=/data/local/tmp/iree/tests/e2e/linalg/check_llvm-cpu_local-task_narrow_n_matmuls.mlir/check_llvm-cpu_local-task_narrow_n_matmuls.mlir_module.vmfb --device=local-task' [==========] Running 6 tests from 1 test suite. [----------] Global test environment set-up....