Scott Todd

Wherever the issue is tracked, can we follow-up and get fixes or patches landed? I've needed to keep patching https://github.com/llvm/torch-mlir/pull/3277 locally as a workaround for compilation crashes for several weeks...

> Actually, I think we already land a more robust fix. [748db31](https://github.com/iree-org/iree/commit/748db3113727de390a4f0a008c9dab3373e33b86) is landed. It should create a valid IR for codegen input. @ScottTodd could you to verify if the...

Do we still want this PR, or can we close it and delete the branch?

This feels like something that should be handled a level or two above IREE. IREE already has support for defining multiple functions and switching between code paths. A framework could...

> Do you have an example of `switching between code paths`? `hal.device.switch` is somewhat specialized, `vm.cond_br` is general purpose control flow. https://github.com/openxla/iree/blob/6a61d9f5e0418fd8322306471cee613c2b31efe7/compiler/src/iree/compiler/Dialect/HAL/IR/HALOps.td#L1298-L1376

We can also update our required status checks to block on all lint checks using this (or we could use the 'summary' style that ci.yml has. Right now we only...

Tip for installing pre-commit: use pipx: https://packaging.python.org/en/latest/guides/installing-stand-alone-command-line-tools/

Started testing this out in IREE with https://github.com/iree-org/iree/pull/17534 and this `.pre-commit-config.yaml` file: ```yml exclude: "third_party/" repos: - repo: https://github.com/pre-commit/pre-commit-hooks rev: v3.2.0 hooks: - id: trailing-whitespace - id: end-of-file-fixer exclude_types: ["image",...

Buildifier has some annoying gotchas: * https://github.com/bazelbuild/buildtools/issues/914 makes it replace Windows style line endings with Linux line endings, marking all files as dirty when using git's `core.autocrlf=true`. For some reason...

Got this mostly done. Remaining work: - [x] Land https://github.com/iree-org/iree/pull/17538 - [x] Switch "required checks" in protected branch settings from previous lint jobs to pre-commit job - [x] Enable `end-of-file-fixer`...