Scott Todd

Results 405 comments of Scott Todd

I don't think we've made any progress on fixing the regression, but I did just put together some tests that demonstrate the issue and will let us guard against similar...

> What's a good way to stack PRs? This depends on #17771 1. Create a branch in this repo instead of a fork (named `users/[username]/[branch name]` - see https://iree.dev/developers/general/contributing/#branch-naming) and...

This is the patch I've created in TheRock to workaround this for now: https://github.com/nod-ai/TheRock/blob/main/patches/amd-mainline/HIPIFY/0003-Don-t-override-CMAKE_C-XX-_COMPILER-on-MSVC.patch ```diff diff --git a/CMakeLists.txt b/CMakeLists.txt index dad79610..f3616fbc 100755 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -115,6 +115,10 @@...

Looking at how some other ROCm projects are set up, overriding `CMAKE_CXX_COMPILER` could be done via toolchain files. For example: * https://github.com/ROCm/rocPRIM/blob/develop/toolchain-linux.cmake * https://github.com/ROCm/rocPRIM/blob/develop/toolchain-windows.cmake It seems like HIPIFY builds just...

Were the updates in https://github.com/iree-org/iree/pull/17661 and https://github.com/iree-org/iree/pull/17568 not recent enough? Why do you want these images updated? (Anything new should be migrating to different images - please help with https://github.com/iree-org/iree/issues/15332...

Dockerfiles were moved to https://github.com/iree-org/base-docker-images. No extra permissions are needed to make changes and publish them now.

What's the latest status here? Do we want to use this as a tracking issue? A few of us are noticing and getting blocked by uneven support for these LinalgExt...

> Which ops are you having issues with? Mainly attention, but I can't tell easily and that's the larger problem. There are several inactive issues like this one and https://github.com/iree-org/iree/issues/17467...

More ideas for refactoring: https://github.com/iree-org/iree/issues/4644#issuecomment-1832433233 (deciding between scoped, incremental improvements and hack-and-slash refactorings...)

Closing in favor of smaller PRs.