Ryan
Ryan
> `WITH_PROTOC` It also doesn't exist in FindProtobuf.cmake. https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/FindProtobuf.cmake On Ubuntu 24, there are no CMake config files distributed, just the pkgconfig file.
> mavproxy_example.py: Done.
This prevents MAVProxy from exiting cleanly. It needs to be sigtermed. MAVProxy does not respect ctrl+C properly, even in the most basic use case.
https://discuss.python.org/t/getting-rid-of-daemon-threads/68836 According to the python maintainers, the recommended approach is to not use daemon threads. https://docs.python.org/3/library/threading.html#thread-objects It recommends instead using e threading [Event](https://docs.python.org/3/library/threading.html#threading.Event) to signal.
Nice work @renzo-sie ! I took a look through your README. Overall, it looks great. A few suggestions - Can you make QOS `lifespan`, `deadline`, and `leaseDuration` a double so...
> > What we really need to do is change to using an alt_frame attribute on Location instead of using these booleans. > > Yes, we do, I've had patches...
> > The key difference is that the presence of AP_FLAKE8_CLEAN is required to be in the file before we validate it the python file. > > Why not remove...
Please split to two commits: 1) AP_DDS: Fix whitespace 2) pre-commit: Upgrade black
Commits look good, ready for merge!
* AP_GPS_GSOF once we have it available as an EAHRS. +1 on EAHRS