Ryan

Setting up CAN on companion computers is hard. This is a nice alternative.

Good improvement. The VN prefix is yours for the taking :)

If you uninstall this, you find that waf can't run. ``` $ ./Tools/autotest/sim_vehicle.py -v ArduPlane -DG --console --enable-dds SIM_VEHICLE: Start SIM_VEHICLE: Killing tasks SIM_VEHICLE: Starting up at SITL location SIM_VEHICLE:...

First action seems to go request to the waf maintainer if they would be interested in following these recommendations: https://peps.python.org/pep-0394/#for-python-script-publishers

> > First action seems to go request to the waf maintainer if they would be interested in following these recommendations: https://peps.python.org/pep-0394/#for-python-script-publishers > > What entry-point are you worried about?...

> can be merged after module update and pip3 -> python3 -m pip I applied those changes. Just needs that fixup squashed into `Tools.`

Need to install pre-commit as part of the normal set of python packages. https://github.com/ArduPilot/ardupilot/actions/runs/5896623868/job/15994803894#step:4:142

> problem on older branches, this is on Copter-4.3:  Looks like we might be able to force an upgrade of `isort` to fix this: https://github.com/home-assistant/core/issues/86892 I'll give it a...

Rebased and fixed the regression. Dropped changes of installing pre-commit automatically. ``` ryan@B650-970:~/Dev/ros2_ws/src/ardupilot$ pre-commit run --all-files Check line ending character (LF).........................................Failed - hook id: mixed-line-ending - exit code: 1 -...

Here's a demo for the CI script with a good PR: ``` ryan@B650-970:~/Dev/ros2_ws/src/ardupilot$ CI_BUILD_TARGET=pre-commit-cleanliness ./Tools/scripts/build_ci.sh ... + echo 'Checking pre-commit code cleanliness' Checking pre-commit code cleanliness + pre-commit install pre-commit...