Ryan

Results 632 comments of Ryan

You got it. Can we define behavior for the result `duration [] total_elapsed_time` and how it's built, particularly for preempts? Here's my proposal with an example where the user calls...

Sorry, I'm not following. Can you clarify your proposed `FollowWaypoints.action` interface? Right now my branch is: ``` # Error codes # Note: The expected priority order of the errors should...

I'm actually confused why there needs to be server-side logging. It seems like the client already have access to the time information. If that's true, why does it need to...

Can I limit the scope to original intention, and save text file saving to another issue?

While I'm working on the UI, should I add a display for the current waypoint and/or loop number? Right now there it's not clear how complete the task is. ![image](https://user-images.githubusercontent.com/25047695/214481067-a62b1b9f-baa2-415f-8046-598f2d9d33ba.png)...

Sounds good, but it doesn't show current waypoint number; I'll create a follow up issue for that. Things are going well otherwise, aside from realizing there was nothing subscribed to...

![image](https://user-images.githubusercontent.com/25047695/214613954-91609dc1-7160-4e07-a0dd-94c997970a05.png) Cool, got it working, PR up in a bit. Before merge, I'd really like to add a few tests to the waypoint follower code.

> Awesome, really cool.. A working GIF of the same would be nice. > > Just a small suggestion, You don't have to go 6 decimal places for the time....

![8c75bd3bd27cd14a4c9c192565f772272279ced6 (1)](https://user-images.githubusercontent.com/25047695/214637992-9f6716a9-6b71-4abc-ab0b-01708390282d.gif) The gif converter messed up the color a bit, but you should get the point.

Yea, looks like it does. ``` ros2 topic echo /geo_path --flow-style header: stamp: sec: 0 nanosec: 0 frame_id: '' poses: [{header: {stamp: {sec: 0, nanosec: 0}, frame_id: ''}, pose: {position:...