RenechCDDA

Results 187 comments of RenechCDDA

> I'm marking this ready for review, because that's what it is: Ready for review. > > I am reasonably confident in it, though I may still push more commits....

> Another thing, the import/export dialog is really confusing if you only have one NPC, because the table is empty. ...Is it? It ends up being an empty table, which...

> Normally one exports things to a file, so it made no sense until I went back and read the source code. Maybe the wording should be changed, and perhaps...

> Want me to send you a pull request? (tl;dr: yes send PR thank you!) I don't think it'd be wrong, I just... prefer? the colored buttons. Basically, -I like...

I don't believe I've made any changes, and just recently got the first and only PR to my fork. But sure, you can just link the branch. I can merge,...

I need to rebase it (to keep the commit history clean-ish) and then check out db48x's branch, I just haven't gotten around to it despite constantly expecting to

> I’m not busy today so I’ll go ahead and rebase for you. I’ll end up with a new PR though. Well I guess that WOULD let me work on...

#73747 resolved the same error caused by (a different?) issue, and may be worth considering.

Looks like there's some error in the json, not sure exactly where. Also I missed adding an entry to the memorial logger. Will need to do it just like this...

This appears to be a horizontal scaling issue, and thus separate