RenechCDDA

Results 187 comments of RenechCDDA

Other places to remove magic 60s: basecamp::validate_sort_points() basecamp::distribute_food() basecamp::form_storage_zones() plot_options::query_seed() (migrate constexpr `ACTIVITY_SEARCH_DISTANCE` in clzones.h ?)

One more: The shadow EOCs reference 60 (as the reality bubble constant), so some sort of TODO note stating that EOCs need to be able to hook into them might...

in eoc-related cpp/h bits sounds fine, just a little TODO note somewhere so it's least on record.

npc::within_boundaries_of_camp has some very sneaky hardcoded references to the current reality bubble size. https://github.com/CleverRaven/Cataclysm-DDA/blob/master/src/npc.cpp#L2503-L2504 Same deal with overmapbuffer::find_camp, actually!

I agree that distance_to_city() seems to be pretty bad. From [one of my other attempts](https://github.com/CleverRaven/Cataclysm-DDA/issues/80528#issuecomment-2800169976) to profile overmap generation I found that distance_to_city() was taking up ~12% of the CPU...

Sorry, those buttons are right next to each other.

The errors related to copying your config folder over appear to be unrelated. (The error from that is tracked in #80679)

Indeed, duplicate. Thank you for reporting this bug. We already have an issue # tracking this. To keep the reports organized (so we can fix them!) your issue will be...

The issue appears to be in item_contents::get_nested_content_volume_recursive() https://github.com/CleverRaven/Cataclysm-DDA/blob/master/src/item_contents.cpp#L2564-L2566 It's... adding the pocket's unused volume? That just seems to be wrong as implemented.

Simply removing those lines is not sufficient, this calculation seems to be totally wrong in general. See it says that we're carrying 0.21L of volume, but we're not. We're carrying...