RenechCDDA

Results 187 comments of RenechCDDA

Okay. This is complicated. You can observe the change in behavior by adding the INCENDIARY ammo_effect back onto gasoline. Removing IGNITE is not sufficient - it must have the INCENDIARY...

This should have worse than bow accuracy, given that it is a crow-served weapon that you are firing at an angle. See also the other things mentioned in #72487

Needs a fix similar to #61098 if confirmed

Structural imager is in fact, Aftershock content not Magiclysm. Bit of a mistake on the tags there. This was introduced by #73325. It should check if the spell is known/exists...

Well this is weird. The function name implies we're always rebuilding the cache, but we're... only sometimes? In any case, this SHOULD be perfectly safe. And I can confirm that...

It sets the seen_cache as dirty **every turn**: https://github.com/CleverRaven/Cataclysm-DDA/blob/6a8d75a468eba3084a616bf3ec700c6e78753c48/src/map.cpp#L9560-L9562 Which then triggers the rebuild of the seen cache. which is the entirety of the hot path during profiling: https://github.com/CleverRaven/Cataclysm-DDA/blob/6a8d75a468eba3084a616bf3ec700c6e78753c48/src/map.cpp#L9580-L9582 I...

>I'm confused about a few things, but the main one is: https://en.cppreference.com/w/cpp/language/static Basically the value held inside the static variable is retained for next time the function is run. >Is...

>Basically the value held inside the static variable is retained for next time the function is run. Oh and that's why it doesn't work in Guardian's testing lol, it needs...

The new GDB is spot on, also reproducible on windows. Only problem is... I have no idea what's going on here. ![image](https://github.com/CleverRaven/Cataclysm-DDA/assets/84619419/8ca37887-e206-44af-a319-d91d336f39ff)

Okay, I see the problem. Vision_transparency_cache is a copy of transparency_cache. Rather obvious when you read the declaration comments, silly Renech. We copy it(always), (then when dirty) we update our...