Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Improper horizontal scaling of Imgui menus

Open bullkang opened this issue 1 year ago • 9 comments

Describe the bug

When opening the Sort dialog window with "Shift + o" not all the text is visible, the menu extends beyond the window size.

Attach save file

Ceiba-trimmed.tar.gz

Steps to reproduce

Open the Sort dialog menu, in my case "Shift + o"

Expected behavior

I expected to have the menu size equal or less then the width of the screen size.

Screenshots

Screenshot_2024-09-07_20-04-01

Versions and configuration

  • OS: Linux
    • OS Version: Distributor ID: Debian; Description: Debian GNU/Linux 12 (bookworm); Release: 12; Codename: bookworm;
  • Game Version: cdda-experimental-2024-09-07-0110 e398be1 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth] ]

Additional context

No response

bullkang avatar Sep 07 '24 10:09 bullkang

It looks like the box is the same on everyone's screen regardless of their terminal width. It looks like its just going to the max width of the description text.

image

CoroNaut avatar Sep 07 '24 10:09 CoroNaut

@CoroNaut is there a setting I could change to have it look like your screenshot? I've tried changing the "Terminal Width" in the "Terminal Display Options" from 160 to 120 to 80 and makes no difference. Any tips?

bullkang avatar Sep 07 '24 10:09 bullkang

My monitor is 1680 x 1050 and my CDDA terminal width/height is 210 x 65 which is (1680 x 1040). I chose those terminal numbers just because they closely match my monitor. I do have 10 pixels at the dead bottom of my screen that are constantly black other than the occasional imgui weirdness that paints overtop of them past the bottom of my screen, so that is something to consider. (lol, you can see those 10 dead pixels in my screenshot above)

CoroNaut avatar Sep 07 '24 11:09 CoroNaut

My monitor is 1600x900, I changed terminal width/height to 210 X 65. Alters nothing, no matter what numbers I place there, nothing changes. Also changed in the Graphical Display Options: Fullscreen, Window Border and Maximized and has had no effect, the display is not changed. I must have something broken...

bullkang avatar Sep 07 '24 11:09 bullkang

I don't think you have something broken, the imgui is definitely in the 'implementation hell' right now and I don't blame it. After it is fully reactive to the terminal width/height, im sure you won't have this problem with it. Also, in the case of your monitor being 1600x900, I'd use terminal 200x56, which is 1600x896 for CDDA. I don't think it'll change anything except make your pixels more crisp and your eyes pleased. :D

Anyways, As for the original issue, it should be fixed eventually, if you don't want to deal with it, you can always take an older version before it was messed up and use that for a while.

CoroNaut avatar Sep 07 '24 20:09 CoroNaut

@CoroNaut Thank you very much for your input, I'll take your advice.

bullkang avatar Sep 07 '24 22:09 bullkang

Closing it as duplicate of #75698, gonna be fixed by #76356

GuardianDll avatar Sep 11 '24 13:09 GuardianDll

This appears to be a horizontal scaling issue, and thus separate

RenechCDDA avatar Sep 11 '24 13:09 RenechCDDA

It’s only this one menu that is out of whack. For now the best fix is to just wrap the text to some sensible length.

db48x avatar Sep 11 '24 22:09 db48x

This bug is only for discussing a single problem with the zone menu. None of the pictures you have posted have anything to do with the zone menu. Why are you posting them here?

db48x avatar Sep 12 '24 10:09 db48x

unfortuately i have to correct you: the first screenshot is out of the zone manager, the resolution is so, that i did not have anything of the text in the frame/window.

ghost avatar Sep 12 '24 10:09 ghost

The other screenshots are not relevant, and therefore not helpful. Each of them is about a different bug that has already been reported. If you want to read the discussions about those other bugs, you can search for them.

Adding another screenshot of the zone menu is not helpful either.

Thank you for trying.

db48x avatar Sep 12 '24 10:09 db48x