Punit Lodha

Results 61 comments of Punit Lodha

Code looks fine, but it needs testing before it can be merged. @prateekmedia @cfsmp3

@prateekmedia Any idea why Windows is failing here?

@prateekmedia have you added this flag already?

@prateekmedia could you add it to this PR itself?

@prateekmedia the tests aren't passing yet

@IshanGrover2004 is this working fine now, after fixing the memory leaks?

@IshanGrover2004 Can you also add a github CI check for running the unit tests

If you find time you can write the extra comments, otherwise it's fine

@prateekmedia also fix the merge conflicts