Punit Lodha

Results 61 comments of Punit Lodha

> This commit conditionally switches between the two. Oh yes, I have not fixed the [encoder assignment for mp4](https://github.com/ArchitBhonsle/ccextractor/blob/rust-persistent-dtvcc/src/lib_ccx/mp4.c?rgh-link-date=2023-03-20T15%3A54%3A17Z#L397). Should I do that too? Yes

> Wait a minute... does this fix #1500 ? I ran this on the link mentioned on the [video](https://drive.google.com/file/d/13p6HBxGXlm0BGpaS15JwCJjfnBdm_Qbm/view?usp=sharing) mentioned [here](https://github.com/CCExtractor/ccextractor/issues/1426#issuecomment-1079731749) and it works. Here's the SMI output: [video.p0.svc01.smi.txt](https://github.com/CCExtractor/ccextractor/files/11021287/video.p0.svc01.smi.txt) (It's...

> I'm sure porting them over to Rust would be better than calling them over FFI. I still think a PR started to specifically fix the persistence of the Dtvcc...

> Dammit another formatting change slipped in. Basically I made some changes to src/lib_ccx/mp4.c and src/rust/src/lib.rs in an attempt to fix the mp4 slow but I'm really not sure if...

> You can set RUST_LOG environment variable. It takes different levels such as race, debug, warn or error. @LPardue that does not work because the examples are missing a logger...

Now you need to create an extern function in `lib.rs` which parses the arguments as passed by the C code, and which can be called by the C code. ```rust...

You'll have to generate bindings for it. Check out `build.rs`

> So now the Args are parsing correctly but the processing output is not visible. @prateekmedia is this fixed?

@prateekmedia could you split out the CI changes into another PR?

@prateekmedia Since you made the change to `rsmpeg`. Is it a drop-in replacement? Are there any changes needed to this PR?