ccextractor icon indicating copy to clipboard operation
ccextractor copied to clipboard
verified publisher icon CCExtractor

[FIX] Initialize data structures for the rust CEA-708 decoder and correct Dtvcc

Open IshanGrover2004 opened this issue 1 year ago • 7 comments

In raising this pull request, I confirm the following (please check boxes):

  • [x] I have read and understood the contributors guide.
  • [x] I have checked that another pull request for this purpose does not exist.
  • [x] I have considered, and confirmed that this submission will be valuable to others.
  • [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [x] I give this submission freely, and claim no ownership to its content.
  • [x] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • [ ] I have never used CCExtractor.
  • [ ] I have used CCExtractor just a couple of times.
  • [ ] I absolutely love CCExtractor, but have not contributed previously.
  • [x] I am an active contributor to CCExtractor.

Closes #1499

Work to be done in this PR:

  • [x] Change Dtvcc::new() to create Dtvcc using ccx_decoder_dtvcc_settings as done here
  • [x] Create a new extern C fn ccxr_dtvcc_init() in lib.rs and use this at all places where dtvcc_init() is being called. (Probably add a new struct field to lib_cc_decode like dtvcc_rust and store Dtvcc there instead of using the dtvcc field)
  • [x] Similar for dtvcc_free()
  • [x] Change ccxr_process_cc_data to use Dtvcc from dec_ctx instead of creating a new one

Additionally to fix mp4 code flow:-

  • [x] Call the corresponding rust function here and pass Dtvcc as done in the above steps

IshanGrover2004 avatar Jun 20 '24 17:06 IshanGrover2004

All checkmarks are done.

But with this sample file I am getting some memory leaks (in debug mode) -- error shown in here

Command used:

./ccextractor ~/Downloads/cc/test_dtvcc.ts --autoprogram --out=ttxt --latin1

IshanGrover2004 avatar Jun 24 '24 18:06 IshanGrover2004

@IshanGrover2004 is this working fine now, after fixing the memory leaks?

PunitLodha avatar Aug 02 '24 08:08 PunitLodha

@IshanGrover2004 is this working fine now, after fixing the memory leaks?

Working fine for some samples @PunitLodha Failing for some regression test, Have to thoroughly look into it for issues

IshanGrover2004 avatar Aug 10 '24 11:08 IshanGrover2004

Is there something wrong with the CI for regression test result msg? @canihavesomecoffee @prateekmedia

IshanGrover2004 avatar Aug 10 '24 17:08 IshanGrover2004

Some weeks before PR was ready. But now when I again visited & ran sample on the rebase with master code, it just crashing at ccx_decoders_708_output.c:591 in dtvcc_writer_init

IshanGrover2004 avatar Aug 24 '24 05:08 IshanGrover2004

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit a34ba0f...:
Report Name Tests Passed
Broken 11/13
CEA-708 6/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 15/27
Hauppage 3/3
MP4 0/3
NoCC 4/10
Options 82/86
Teletext 21/21
WTV 13/13
XDS 26/34

Your PR breaks these cases:

Congratulations: Merging this PR would fix the following tests:


It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

ccextractor-bot avatar Aug 24 '25 16:08 ccextractor-bot

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 39e051b...:
Report Name Tests Passed
Broken 0/13
CEA-708 0/14
DVB 0/7
DVD 0/3
DVR-MS 0/2
General 0/27
Hauppage 0/3
MP4 0/3
NoCC 0/10
Options 0/86
Teletext 0/21
WTV 0/13
XDS 0/34

Your PR breaks these cases:

NOTE: The following tests have been failing on the master branch as well as the PR:


It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

ccextractor-bot avatar Aug 24 '25 16:08 ccextractor-bot