Punit Lodha

Results 61 comments of Punit Lodha

The file with `.pX.svcYY` extension is for CEA 708 subtitles, and the other one is for CEA 608 subtitles. Earlier, 708 subs were extracted only if the `-svc` flag was...

This is how it works now, - 708 `-svc` and field 1(i.e. 608) `-1` are enabled by default - if no params are provided:- extract whatever is available, if both(708...

So, for some reason, mp4 still uses the C decoder. And changing it to rust is not as straightforward. I am working on it. Meanwhile, @voidash could you replicate the...

`main.scc` will be empty because it is supposed to contain subs for 608, which is not present here. `main.p0.svc01.scc` is the file which is supposed to have 708 subs. So...

I did look at that. But due to how the code is structured, it's not as easy as just calling the rust function from there. I'll have to change some...

@voidash >So 708 decoder found SCC subs which means `Scenarist_SCC V1.0` header should be added on top of the `main.p0.svc01.scc` Check out how sami header is added, and do it...

VOB files have multiple chapters. So when a new chapter starts, time resets to 0. Isn't that the correct behaviour?

Oh, ok. I misunderstood that part. Will try to fix it

Please fix the formatting issues by running clang-format and rustfmt