ccextractor icon indicating copy to clipboard operation
ccextractor copied to clipboard

[rust] add parser

Open prateekmedia opened this issue 1 year ago • 2 comments

In raising this pull request, I confirm the following (please check boxes):

  • [x] I have read and understood the contributors guide.
  • [x] I have checked that another pull request for this purpose does not exist.
  • [x] I have considered, and confirmed that this submission will be valuable to others.
  • [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [x] I give this submission freely, and claim no ownership to its content.
  • [ ] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • [ ] I have never used CCExtractor.
  • [ ] I have used CCExtractor just a couple of times.
  • [ ] I absolutely love CCExtractor, but have not contributed previously.
  • [x] I am an active contributor to CCExtractor.

Rewrote argument parsing with all the structs and enums too into rust.

Help arguments demo: image

Closed old PR as sample platform broke for it: #1547

prateekmedia avatar Jun 26 '24 12:06 prateekmedia

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f12f12b...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 24/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 78/86
Teletext 21/21
WTV 1/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

ccextractor-bot avatar Jul 06 '24 22:07 ccextractor-bot

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit d6ccf1b...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 83/86
Teletext 21/21
WTV 13/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

ccextractor-bot avatar Jul 07 '24 09:07 ccextractor-bot

@prateekmedia also fix the merge conflicts

PunitLodha avatar Aug 02 '24 08:08 PunitLodha

@PunitLodha Done!

prateekmedia avatar Aug 05 '24 21:08 prateekmedia

@prateekmedia could you take a look at why the CI is failing

PunitLodha avatar Aug 09 '24 09:08 PunitLodha

@PunitLodha Done!

prateekmedia avatar Aug 09 '24 13:08 prateekmedia

@prateekmedia @PunitLodha Are the sample test ran on this PR, Because I tested some samples on current CCExtractor code & its crashes which was working fine before this merging happens (I checked on each commit through when it is failing, found out this is the one which causes).

Sample platform on commit - Linux & Windows

IshanGrover2004 avatar Aug 25 '24 07:08 IshanGrover2004

@IshanGrover2004 The teletext PR will resolve the crashes currently.

prateekmedia avatar Aug 25 '24 08:08 prateekmedia