ccextractor icon indicating copy to clipboard operation
ccextractor copied to clipboard

[WIP] Set up a Rust native version of Hardsubx context and rewrite hardsubx.c

Open shashwat1002 opened this issue 3 years ago • 6 comments

  • constructor function (new) made that takes options as argument [this will replace init_hardsubx]
  • default function for hardsubx context
  • default function for cc_subtitle

shashwat1002 avatar Oct 31 '22 16:10 shashwat1002

@PunitLodha please check if the new struct looks okay

shashwat1002 avatar Oct 31 '22 17:10 shashwat1002

@prateekmedia Since you made the change to rsmpeg. Is it a drop-in replacement? Are there any changes needed to this PR?

PunitLodha avatar Mar 14 '23 23:03 PunitLodha

@PunitLodha you can check what the CI says for build_ocr_hardsubx linux, if it runs fine then no change else I think there might be some imports that need to be done.

Like ffmpeg_sys_next::* would not be equivalent to rsmpeg::*, some dependencies are needed to be include manually. Check my implementation on mod.rs and utility.rs

prateekmedia avatar Mar 15 '23 02:03 prateekmedia

@prateekmedia @IshanGrover2004 @PunitLodha thoughts on this PR?

cfsmp3 avatar Mar 03 '24 17:03 cfsmp3

Code looks fine, but it needs testing before it can be merged. @prateekmedia @cfsmp3

PunitLodha avatar Aug 12 '24 14:08 PunitLodha