ccextractor icon indicating copy to clipboard operation
ccextractor copied to clipboard

[FEATURE] Create unit test for rust code

Open IshanGrover2004 opened this issue 1 year ago • 2 comments

In raising this pull request, I confirm the following (please check boxes):

  • [x] I have read and understood the contributors guide.
  • [x] I have checked that another pull request for this purpose does not exist.
  • [x] I have considered, and confirmed that this submission will be valuable to others.
  • [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [x] I give this submission freely, and claim no ownership to its content.
  • [x] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • [ ] I have never used CCExtractor.
  • [ ] I have used CCExtractor just a couple of times.
  • [ ] I absolutely love CCExtractor, but have not contributed previously.
  • [x] I am an active contributor to CCExtractor.

Creating Unit test cases for rust modules(decoder + hardsubx). Closes #911

IshanGrover2004 avatar Jun 01 '24 10:06 IshanGrover2004

The decoder moulde's unit test done @PunitLodha

IshanGrover2004 avatar Jun 09 '24 10:06 IshanGrover2004

@IshanGrover2004 Can you also add a github CI check for running the unit tests

PunitLodha avatar Jul 09 '24 11:07 PunitLodha

Sure @PunitLodha

IshanGrover2004 avatar Jul 09 '24 12:07 IshanGrover2004

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f12f12b...:

Report Name Tests Passed
Broken 12/13
CEA-708 13/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 23/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 84/86
Teletext 21/21
WTV 9/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

ccextractor-bot avatar Jul 09 '24 16:07 ccextractor-bot

@PunitLodha @cfsmp3 You can proceed for merging. I have added CI + all modules unit test cases

IshanGrover2004 avatar Jul 18 '24 04:07 IshanGrover2004

If you find time you can write the extra comments, otherwise it's fine

PunitLodha avatar Aug 02 '24 08:08 PunitLodha

@PunitLodha Added the CI & fixed the warnings as well

IshanGrover2004 avatar Aug 10 '24 14:08 IshanGrover2004