Nathan Daly comments

Results 286 comments of


                                            Nathan Daly

Reduce overhead running with Mocking activated but no patches applied

> > `Mocking.apply` could set a global / ScopedValue `PATCH_ENV_ACTIVE::Bool` that can be checked alongside `activated()` to avoid calling `get_alternate` at all > > I'm skeptical we can improve performance...

It should be an error to `@patch` a function that isn't `@mock`ed. Currently it is silently ignored.

Oh, hang on. I might be wrong about this. I've forgotten how this package works. You don't `@mock` the function _definition_, you mock its callsites... So there's nothing wrong with...

persistent_task should respect the environment

😬 no, i don't have much of an idea about that. I'm not really clear on why it would be harder, even. Can you share more info?

fix method ambiguities

Thank you 🙏

Wrong "Cannot define function ; it already has a value."

Here's a screenshot of the false positive error

get rid of Pkg dependency

Looks to have some failures on `nightly`, but I assume they're unrelated? Can you confirm?: ``` macro preserves comments 1: Test Failed at /home/runner/work/AutoHashEquals.jl/AutoHashEquals.jl/test/runtests.jl:79 Expression: plain(#= /home/runner/work/AutoHashEquals.jl/AutoHashEquals.jl/test/runtests.jl:79 =# @doc(T23)) ==...