Nathan Daly comments

Results 286 comments of


                                            Nathan Daly

`KeyError: key :S not found` in `map_ssas_to_source`

This MRE passes on julia 1.11, but fails on 1.10. Error first, then the source file at the end: ```julia (@v1.10) pkg> st Status `~/.julia/environments/v1.10/Project.toml` [69d22d85] About v1.0.1 [1520ce14] AbstractTrees...

Macros juxtaposed with strings incorrectly(?) get raw string literal

🤔 I actually think you could leave the Lexer as-is. Given the above tokens, i think we could still raise an Exception later on in parsing/lowering from the juxtaposed macro...

Macros juxtaposed with strings incorrectly(?) get raw string literal

But that said: > but I really feel the @ in front of the module name is horrible syntax and should be deprecated!) +1

better error for begin-end in typed comprehension

Oh interesting. makes sense, i guess. A more instructional error message would certainly have helped, but i know those are difficult from within a parser.

A GC triggered while a thread is blocking on the GIL lock can freeze julia forever

CC: @kpamnany, since you've fixed similar kinds of hangs in other packages. Does a global ReentrantLock to protect the GIL seem like the right fix to you?

A GC triggered while a thread is blocking on the GIL lock can freeze julia forever

Huh... So, someone _else,_ who is not the code who locked the GIL, can _unlock_ the GIL? That ... doesn't seem great. If so, then yes the concerns you raised...