Aqua.jl icon indicating copy to clipboard operation
Aqua.jl copied to clipboard

persistent_task should respect the environment

Open thofma opened this issue 1 year ago • 3 comments

As I learned from @lgoettgens:

The persistent task test does not work with deved dependecies

Would be great if it could work with deved dependencies. I guess this boils down to respecting the environment when spawning the test.

thofma avatar May 04 '24 11:05 thofma

@timholy @NHDaly since you two introduced the test_persistent_tasks test, do you have any idea on how to adapt it to respect deved dependencies (and more general all dependencies that are not just taken from the registry, but via a local path, a git revision etc.)?

lgoettgens avatar Oct 10 '24 13:10 lgoettgens

😬 no, i don't have much of an idea about that. I'm not really clear on why it would be harder, even. Can you share more info?

NHDaly avatar Oct 18 '24 19:10 NHDaly

I'm also unsure what this is about. But looking at the code, I noticed two Pkg-related and one julia-options candidates:

  • https://github.com/JuliaTesting/Aqua.jl/blob/1fca5d9fc494a1c80618d7352655373be7c8d82c/src/utils.jl#L38
  • https://github.com/JuliaTesting/Aqua.jl/blob/1fca5d9fc494a1c80618d7352655373be7c8d82c/src/persistent_tasks.jl#L81
  • https://github.com/JuliaTesting/Aqua.jl/blob/1fca5d9fc494a1c80618d7352655373be7c8d82c/src/persistent_tasks.jl#L112

Since I don't know what you're experiencing, this is a blind guess. Perhaps passing more info into precompile_wrapper would fix it?

timholy avatar Oct 21 '24 11:10 timholy