Nathan Daly

Results 286 comments of Nathan Daly

I wonder whether we might want to separate the process handling testitems and the process doing the rest of the work in the LS? Even if we're able to shrink...

Regarding the rest of your ask: I'll try that, yeah. I will note that the issue was repeatable, so it is slow for a while. But yeah i'll try again,...

Ah, it looks like i've been suffering from https://github.com/julia-vscode/julia-vscode/issues/3037. I wonder if this was causing the server to keep restarting? EDIT: Aha, yes, now that i'm watching the `Output` tab,...

To confirm: you aren't seeing the warnings you describe inside of a testitem, correct? We fix that via the change that Nick described. For issue 1, yes, this is a...

(The disadvantage is that every field access has to go to the heap. With an immutable struct, fields can be pulled onto the stack or into registers, which can improve...

I think i agree with @nystrom. Or at least, you could consider asserting that there's only a single struct declaration in there. It seems it would a bit strange to...

hrmm yeah those are good points! Sorry for my long delay. 🤔 Yeah i don't have a great suggestion here then... It's worth noting that i think macros run outside-in,...

Related to the above, I just wanted to comment that the current error message for the very simple reproducer is not helpful: ```julia julia> using JSON julia> JSON.parse("") ERROR: Unexpected...

Probably the best next step is a bisect to figure out which commit introduced the error in between 1.6 and 1.9?

@IanButterworth: Thanks for the original fix! We find though that for a large codebase like ours, adding threads still makes a significant difference, e.g. some of our tests go from...