AutoHashEquals.jl icon indicating copy to clipboard operation
AutoHashEquals.jl copied to clipboard

get rid of Pkg dependency

Open KristofferC opened this issue 1 year ago • 3 comments

we can use Base.pkgversion if we restrict ourselves to julia 1.9+

KristofferC avatar Aug 22 '24 13:08 KristofferC

@NHDaly, do you still have commit access to this repo?

KristofferC avatar Sep 09 '24 10:09 KristofferC

Looks to have some failures on nightly, but I assume they're unrelated? Can you confirm?:

macro preserves comments 1: Test Failed at /home/runner/work/AutoHashEquals.jl/AutoHashEquals.jl/test/runtests.jl:79
  Expression: plain(#= /home/runner/work/AutoHashEquals.jl/AutoHashEquals.jl/test/runtests.jl:79 =# @doc(T23)) == "a comment\n"
   Evaluated: "Base.Docs.DocStr(svec(\"a comment\"), nothing, Dict{Symbol, Any}(:typesig => Union{}, :module => Main.runtests, :linenumber => 75, :binding => Main.runtests.T23, :path => \"/home/runner/work/AutoHashEquals.jl/AutoHashEquals.jl/test/runtests.jl\"))\n" == "a comment\n"

NHDaly avatar Sep 16 '24 19:09 NHDaly

:) Thanks for the PR, Kristoffer!

NHDaly avatar Sep 16 '24 19:09 NHDaly

Okay, I confirmed the nightly tests fail independent of this PR: https://github.com/JuliaServices/AutoHashEquals.jl/pull/53.

So this is good to merge.

NHDaly avatar Oct 01 '24 16:10 NHDaly

Registering new version: https://github.com/JuliaServices/AutoHashEquals.jl/commit/1956b026c43ff4f10cbe715816dc3ca2fb7eea89#commitcomment-147443431

NHDaly avatar Oct 01 '24 16:10 NHDaly