FixedPointDecimals.jl icon indicating copy to clipboard operation
FixedPointDecimals.jl copied to clipboard

fix method ambiguities

Open kuszmaul opened this issue 1 year ago • 1 comments

julia> using FixedPointDecimals
julia> using Aqua
julia> Aqua.test_all(FixedPointDecimals)
13 ambiguities found. To get a list, set `broken = false`.
Ambiguity #1
(::Type{T})(x::FixedPointDecimals.FixedDecimal) where T<:Union{AbstractFloat, Integer, Rational} @ FixedPointDecimals ~/.julia/packages/FixedPointDecimals/SHo3T/src/FixedPointDecimals.jl:521
Bool(x::Real) @ Base float.jl:171

Possible fix, define
  Bool(::FixedPointDecimals.FixedDecimal)
...

kuszmaul avatar Aug 28 '24 10:08 kuszmaul

Thank you 🙏

NHDaly avatar Aug 28 '24 15:08 NHDaly