Nathan Daly

Results 286 comments of Nathan Daly

I also updated the PR comment with the final perf numbers, which look 👌

Oh wow, very nice! Thanks @EdsterG. 💪 This should still help quite a bit, but the baseline for comparison would be better in 1.11, then! 💪

Cool, thanks! 🎉 🤔 Is it expected that the currently-scheduled tasks seem to have their stacks **starting at a different frame** than the waiting tasks? It looks like the executing...

My instinct is that this is not desirable, and we should figure out why they're different, and correct that.

A discovery I've made: Even though `Pkg.test("SubPackage")` and `using SubPackage` both work correctly already, it looks like `Pkg.instantiate()` does not! 💡 ```julia julia> using Pkg julia> Pkg.activate("packages/RAI_Metrics/") Activating project at...

Actually, changing that line to ```julia Pkg.instantiate(ctx; allow_autoprecomp = false) # do precomp later within sandbox ``` seems like a good idea. Copied that from here: https://github.com/JuliaLang/Pkg.jl/blob/27c1b1ee5cf15571eb5e54707e812d646ac1dde3/src/Operations.jl#L2217 But we still...

😊 Aha, it makes sense: i think we just need this line at the end: ```julia # Now that we have set up the sandbox environment, precompile all its packages:...

Note: we are encountering a race condition in our application, which we _think_ might trace back to this package, though we still aren't sure. In the process of investigating that,...

Oh interesting! If that's true, it would be very good to document that, indeed!! 👍 We ended up dropping the package from our project, but documenting it would be great...

I'm not sure i understand why the VariableTimeZones still alloc when you look them up. I agree with you it is unexpected.. I'm not sure the isbits thing should matter,...