Moritz Bender

Results 183 comments of Moritz Bender

After having much trouble in figuring out what to do (setup.py seems outdated) I was able to build using the command in the readme and installing it seems to have...

Well, this feature seems to be intended for `git blame` only; it works here: https://github.com/YoshiRulz/git-blame-ignore-revs-poc/blame/master/src/BizHawk.Client.EmuHawk/EmuHawkUtil.cs

https://github.com/Morilli/BizHawk/blame/master/.editorconfig ... I think that's working?

While some of these changes (like converting heap allocations to stack allocation and thereby reducing GC load) seem like senseful changes we probably want, I cannot seem to reproduce your...

It would probably be interesting to get data from other people, or alternatively figure out why you're seeing such a high cost of `wbx_activate_host`, because this is how it looks...

Thoughts on this? ```diff diff --git a/src/BizHawk.Client.EmuHawk/MainForm.cs b/src/BizHawk.Client.EmuHawk/MainForm.cs index 2dbc0b6f1..f1e45e0b2 100644 --- a/src/BizHawk.Client.EmuHawk/MainForm.cs +++ b/src/BizHawk.Client.EmuHawk/MainForm.cs @@ -2983,7 +2983,7 @@ namespace BizHawk.Client.EmuHawk SyncThrottle(); _throttle.signal_frameAdvance = _runloopFrameAdvance; _throttle.signal_continuousFrameAdvancing = _runloopFrameProgress; - if...

I think the issue is that this isn't possible currently; the `_lastFastForwardingOrRewinding` is never `false` when being in a paused state while `unthrottled` speed is active, and I couldn't find...

@zeromus your suggestion does nothing except disabling the fps display, as `_lastFastForwardingOrRewinding` is set again afterwards.

@nattthebear going to tentatively request feedback here; everything should work, but I'm not very sure about the entire sound system.

> So what's doing the 32k -> 44.1k resampling now? I think it's https://github.com/TASEmulators/BizHawk/blob/master/waterbox/bsnescore/bsnes/nall/dsp/resampler/cubic.hpp... I can't really tell you how it's working or what it's doing though.