Moritz Bender
Moritz Bender
If mgba can handle invalid address reads just fine, then why not just remove the exception? The only alternative I see is to throw memory domain size checks everywhere, and...
Of course, I'm only talking about the debugger/disassembler situation here.
It would probably fix this specific issue, but it begs the question why only one of the ~15 disassembler implementations needs to check the supplied address for validity. Are all...
> s/specified/not nil/ I disagree. The entire documentation uses "specified" and why would you ever explicitly provide `nil` and expect the result to differ from not providing it at all?...
Seeing as #2600 has been resolved, can this be closed?
Okay, unless there's any further disagreement I'll just merge this later then; I've resolved the previous review comments myself.
This may help:
There is also a problem in Obsidian:
> You should keep in mind that in the future I don't intend to support this in any kind of software since it should be doable only from disk. This...
Are you sure this is not a riot issue? After all, the map is not playable yet, so maybe it is not entirely completed yet.