Moritz Bender

Results 230 comments of Moritz Bender

> Are you saying we should make that even clearer, maybe "val is the value to be read"? Or is it that existing implementations don't match the docs? Both, probably....

> WinForms projects can't be trimmed (BizHawk.Client.EmuHawk [...] So this means it cannot be enabled AT ALL until we move away from winforms, right?

Yeah I don't think trimming is gonna happen any time soon. Reflection is just one example of many patterns that are not compatible with trimming and are extremely hard to...

Do you have lua 5.4 installed on your system?

Did a quick test and I can confirm two files get created. The first one seems like an erroneously generated file because it doesn't seem to contain any data, while...

Yeah you probably need a better video player than windows' default for these video files; it should play fine in your browser though.

> The code is correct, or at least it correctly implements the desired behaviour according to that comment. (UX needs work, as usual...) How about something like one option saying...

How about just updating all dependencies while we're at it?

The main rationale behind having the `IO.Extensions` part split was that other projects wouldn't need to pull in the reasonably large `Sixlabors.Imagesharp` dependency when they don't need it.

I imagine the main "big" dependency is the `Microsoft.CodeAnalysis.CSharp` required by the MetaDump generation code. You can check the specific dlls that are large in your output by not publishing...