Mirror

Mirror copied to clipboard

maxconnections exploit maybe

2

copy paste from discord: "here's an exploit: connect maxConnection clients, send ping/pong (low performance cost) but not ready/addplayer. boom no new clients can join the server"

miwarnec

**Describe the bug** A malicious client can send as many ReadyMessages as they want and cause observers to be rebuilt every time (potentially slow): https://github.com/vis2k/Mirror/blob/64f247fb32e49e833f4e243ef051056cd3a056df/Assets/Mirror/Runtime/NetworkManager.cs#L1073-L1078 https://github.com/vis2k/Mirror/blob/64f247fb32e49e833f4e243ef051056cd3a056df/Assets/Mirror/Runtime/NetworkManager.cs#L1176-L1184 https://github.com/vis2k/Mirror/blob/64f247fb32e49e833f4e243ef051056cd3a056df/Assets/Mirror/Runtime/NetworkServer.cs#L668-L678 **Expected behavior** NetworkServer.SetClientReady...

imerr

Add Interface for a port field for Transports so that it is easier to set

6

we should add an interface to set the port, this will maker it easier for users to cast the transport and then set the port ```cs public interface IPortTransport {...

James-Frowen

In project when ofthen exchange behaviour during runtime... In NetworkBehaviour class I have initialized some implementation of IActionBehaviour which exchange during runtime. It would be really good and flexible if...

Jerichos

Async spawning to better support Addressables

7

## Please explain the suggested feature in detail. [Addressables](https://docs.unity3d.com/Packages/[email protected]/manual/AddressableAssetsGettingStarted.html) allows prefabs to be loaded from asset bundles at runtime. Prefabs are normally spawned via ```cs Addressables.InstantiateAsync("AssetAddress"); ``` or ```cs Addressables.LoadAssetAsync("AssetAddress");...

James-Frowen

EndOfStreamException: ReadString too long during network discovery

1

Using Mirror, on an Android device, I start the host over a 5ghz local network. In Unity, using the editor, I begin Network Discovery. Intermittently, this error occurs - from...

netpoetica

Breakpoints fail to hit in classes inheriting NetworkBehaviour with partial classes

1

**Describe the bug** Visual Studio breakpoints fail to hit with partial classes in certain circumstances. If a NetworkBehaviour inheriting class is split up into several files using partial classes, only...

lumeriith

**Please explain the suggested feature in detail.** As mentioned in the summary above OnRoomServerPlayerReady() method: _"By implementing this callback you can customize what happens when all the players in the...

Chefty

Hello, some of you knows me already from discord. They like my stuff what I try also they hate me because I break mirror or telepathy sometimes. I very often...

MaZyGer

I get "there is already a player for this connection" if players connect to a new game after ending and disconnecting a game, without restarting the application.

3

I get the same error if players connect to a new game after ending and disconnecting a game, without restarting the application. The error also prevents the game from starting...

RyanAllem