Mirror
Mirror copied to clipboard
ReadyMessage spam -> forced observer rebuilds
Describe the bug A malicious client can send as many ReadyMessages as they want and cause observers to be rebuilt every time (potentially slow): https://github.com/vis2k/Mirror/blob/64f247fb32e49e833f4e243ef051056cd3a056df/Assets/Mirror/Runtime/NetworkManager.cs#L1073-L1078 https://github.com/vis2k/Mirror/blob/64f247fb32e49e833f4e243ef051056cd3a056df/Assets/Mirror/Runtime/NetworkManager.cs#L1176-L1184 https://github.com/vis2k/Mirror/blob/64f247fb32e49e833f4e243ef051056cd3a056df/Assets/Mirror/Runtime/NetworkServer.cs#L668-L678
Expected behavior NetworkServer.SetClientReady should return early if isReady is already true (this might break stuff, I'm not too familiar with the ready part of the code)