Matan Borenkraout

Results 228 comments of Matan Borenkraout

Hi @poteto! Any chance to merge this one? :)

Thanks for opening this one @rodpatulski. If I understand correctly, we're not `await`ing for the unmount, we're just calling [`root.unmount()`](https://github.com/testing-library/react-testing-library/blob/73ee9ba13cb4b337f06e2ed61099d6af9a4968da/src/pure.js#L81) so what you're experiencing seems reasonable. There's probably something happening...

Hi @jayneesh.. As @mstangret, it looks like you need to await for something but we won't be able to help without a reproducible example. In fact, these kind of questions...

PR's are welcome for this if anyone wants to fix it in the README and state that version >=13 requires React >=18.

Hi @brianHaleyEmpire, thanks for opening this one. I must say I don't agree with the approach since browsers don't implement "typing" that way and the purpose of `user-event` is to...

@stefee sorry it took me some time to get to this. I saw the reproduction and I'm leaning towards saying that this should be handled in the user land as...

You are correct, but they just recommend you to catch the error inside the event handler. Once you decide not to catch it and throw it, if I'm not mistaken,...

Hi @RUANDUARTE03.. This issue is still missing some important stuff. Does this happen in local environment? Is your package-lock file pushed and updated? It looks like you're running `npm ci`...

> Usually there have been more difficulty with our repo than with other libs in the testing-library org because unlike other libs, this one is not used via direct imports....

I think the only open thing left is to update the codesandbox examples. If anyone still wants to take it, this is open :)