Matan Borenkraout comments

Results 228 comments of


                                            Matan Borenkraout

`screen` incompatible with document.body.replaceWith()

I'm hesitating whether this is a valid use case we should be supporting. What are the use cases to actually replace the entire body of the document? This isn't something...

`fireEvent.drop` API behaves not as expected about preventDefault in Browser and js env

Hi @electroluxcode, thanks for taking the time to open this. `fireEvent` is a very low level API, all it does is dispatch the event based on the configuration. I think...

Failing CI build

I think we can safely pin the version to unblock releases :)

Replace `chalk` with `picocolors`

Thanks @Fuzzyma for raising this. I'm open to reviewing a PR that either removes the library or replaces it with `picocolors` :)

chore(deps): replace chalk with picocolors

Thanks @benmccann for the ping. I've just merged https://github.com/testing-library/jest-dom/pull/659, let's see we're not seeing any regressions there and I'll merge this one in the upcoming week :)

Disable callToJSON option used by pretty-format

Thanks @AdrienClairembault. Can you please open an issue with a reproduction of the problem so we'll understand what we're trying to fix here with a real life example? Also, I'm...

Remove contradiction from documentation

Hi @skonky, thanks for this. This is not true anymore for all of our framework wrappers. RTL for examples does not include DTL anymore. I believe that this should be...

Flaky Tests with user.type (missing characters)

Hi @mzietlow, thanks for opening this. I actually tried to reproduce it on our reproduction repo and looks like the test is passing, might be something related to other dependencies...

Log from .logTestingPlaygroundURL is to big and not working

> I get this error all the time. To reproduce it you just need to render a component big enough. For some our tests we have to render a huge...

Log from .logTestingPlaygroundURL is to big and not working

Any chance to get an example here? For the example attached above I do see the HTML at the left.