Matan Borenkraout comments

Results 228 comments of


                                            Matan Borenkraout

`getByRole('insertion')` and `getByRole('deletion')` do not match semantic `<del>` and `<ins>` tags

Thanks @rdwoodring, appreciate you taking the time to test it. Currently, I'm out of capacity to test it in some of my projects, that's why we're holding it back. If...

`getByRole('insertion')` and `getByRole('deletion')` do not match semantic `<del>` and `<ins>` tags

Thanks @jlp-craigmorten :)

findByRole() finds no candidates

Hi @Dreamsorcerer! Thanks for taking the time to work on this. Can you please create a reproduction using [https://testing-library.com/new-dtl](https://testing-library.com/new-dtl)?

getByTestId not working when upgrading @testing-library/dom from version 9.3.1 to 9.3.2 or above

Thanks @jlp-craigmorten, I believe that's the issue. @valleywood, if it's not the issue please re-open :)

getByTestId not working when upgrading @testing-library/dom from version 9.3.1 to 9.3.2 or above

Nope, that's not related. You can see in the error message that your element uses `data-test-id="123"` whereas the selector is looking for `[data-testid="123"]`, `data-testid` is the default test id we...

getByTestId not working when upgrading @testing-library/dom from version 9.3.1 to 9.3.2 or above

This might be related to multiple different `@testing-library/dom` version installed, can you please check if you have different version installed?

getByTestId not working when upgrading @testing-library/dom from version 9.3.1 to 9.3.2 or above

Hmm, actually, we might need to take a look into it or at least document it. I'm not sure based on this log why you have multiple version installed though,...

#1179: Specify default ontimeout at configuration level

Thanks for this contribution. I'm hesitating whether this is a use-case that should be built-in in the library. Do we believe users will want to configure it on their own?...

release: 10.0.0

Yeah, I indeed didn't get a chance to follow through on this release because I didn't have enough spare time. We still want to test this release in some projects...

release: 10.0.0

I've ran some tests on a project I work on and they pass with no regression. I'll mark this as ready for review and will try to push it soon.