Matan Borenkraout

Results 228 comments of Matan Borenkraout

Hi @gnesher! Thanks for opening this one. The last version of DTL 7 was released almost 3 years ago, we're not supporting that anymore and a lot has changed since...

Thanks @cmorten! This is indeed resolved in DTL version 10 which was just released a few hours ago: Repro: https://stackblitz.com/edit/rtl-template-lxaduy?file=package.json,src%2FApp.test.tsx

Thanks @M0nica! This is actually a regression I created back then because I didn't have the time to find dark mode logos for some of our users. The code is...

Oh, no worries, thanks @rickhanlonii!

@vhakulinen Feel free to move forwards with this PR/create a different PR :)

> Unfortunately, I don't have the bandwidth to do that at the moment. > > (I hope my comment didn't come off as rude, I really appreciate all the work...

@ghostd Thanks for letting us know, but unfortunately, that commit wasn't released yet, the latest release is 5.1.3 which was released at the end of October 2022. ![image](https://user-images.githubusercontent.com/12711091/221849203-cdf47c35-4a13-42bb-880d-710b65935a5e.png)

:tada: This issue has been resolved in version 10.0.0 :tada: The release is available on: - [npm package (@latest dist-tag)](https://www.npmjs.com/package/@testing-library/dom/v/10.0.0) - [GitHub release](https://github.com/testing-library/dom-testing-library/releases/tag/v10.0.0) Your **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:

Hi @ITenthusiasm! Thanks for taking the time to open this issue. This is going to be a tough one. We're using `aria-query` for the implicit role mappings and they follow...

@weilbith `details` has an implicit role of `group` and not explicit, explicit means you add it on your own. The `name` attribute is not the accessible name which is used...