Matan Borenkraout
Matan Borenkraout
I'm closing this one in favor of #484, let's discuss it there :) Thanks!
> I noticed that this issue is still open. Let me know if I can assist in resolving it or perhaps re-create an MR based on the changes from the...
Hi @thany :) AFAIU, this was already pushed to `aria-query` in [this commit](https://github.com/A11yance/aria-query/commit/f7f6120770088f7259c38d8a99e629290c343abc) but unfortunately, aria-query hasn't released a new version containing this change to npm yet. Once they'll release...
~~@thany Looks like a new version of `aria-query` was released, can you please re-install testing-library to get the latest version and see if this works now? Thanks :)~~ Edit: We've...
:tada: This issue has been resolved in version 10.0.0 :tada: The release is available on: - [npm package (@latest dist-tag)](https://www.npmjs.com/package/@testing-library/dom/v/10.0.0) - [GitHub release](https://github.com/testing-library/dom-testing-library/releases/tag/v10.0.0) Your **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:
Hi @xupea! Thanks for working on this. It might take me some time to review this one but I'll put it on my list :)
I believe translations is a good idea and 100% agree that we should add ground rules for the contribution guidelines and talk about it a bit before merging :)
@nazarepiedady I didn't get the chance to review this one. I'll do my best to get to it soon :)
Thanks @cmorten! Since this one isn't maintained by our organization we'd be happy if someone will contribute a page to our frameworks section :)
Is there any chance that there's something async going on there? Did you try wrapping the assertion in a `waitFor`?