Matan Borenkraout

Results 228 comments of Matan Borenkraout

Do we want to publish it to both netlify and github pages? Docusaurus has a good configuration to publish to github pages so it won't be a mess, we'll just...

@nickmccurdy @afontcu is this still relevant or we can close it? :)

Now that #487 was merged, I can take this one. Any important stuff to keep in mind when working on it?

@alexkrolick do you have experience with publishing some docs to the docset? It really looks not straightforwards as I thought it would be.. I guess we'd want to use something...

> Ugh, looks like the commit hook broke the formatting on some of these. Sorry, still didn't get the chance to fix that :/ > The color contrast in light...

@nickmccurdy did the formatting break anything? I only see that it removed some parens..

> I didn't choose the colors, this is the stock theme for Docusaurus 2. I agree that the accessibility is an issue here, but having a visual distinction between different...

Regarding the migration of Docusaurus to v2, It looks like V2 is in alpha for a lot of time now and is stated as stable so I think this can...

> Maybe docs for frameworks could be as simple as Cypress' https://testing-library.com/docs/cypress-testing-library/intro I think that having one page per framework is a great idea, but IMO looking at React framework...

Hi @vapurrmaid and @jsjoeio, thanks for taking the time to open this :) This is actually on purpose, we didn't want to "couple" both of the libraries as this ability...