Marc-Alexandre Côté
Marc-Alexandre Côté
@TheCrazyT have you run the tests (maybe with appveyor)? I'm not sure the third-party dependencies (i.e. git-glulx and Inform7) will work (i.e. TextWorld will fail at runtime).
Thanks @TheCrazyT for doing this. That's really great. I just want to highlight that the current version of TextWorld is 1.2, and 1.3 will be released soon (coming weeks).
@TheCrazyT good point about Jericho not supporting Windows. In theory, you don't have to use Jericho with TextWorld (only git-glulx is fine). I have to look at how to do...
Hi, I can have a closer look next week. I'd be happy to review a PR fixing that issue.
@daniel-ge the link to the data is now invalid.
Thanks for letting us know. There is some work in progress about making tractogram manipulation more robust in Dipy (https://github.com/nipy/dipy/pull/1812). Hopefully, we'll be able to bring most of the checks...
I totally agree with @effigies. Adding more people to the discussion. @frheault @jchoude
I agree with @effigies, we should preserve format-specific metadata as much as possible. I think what you propose is the right direction.
Finally got some time around to finish my testing. I can't reproduce the same timing as you originally posted @emanuele. Here's the simple benchmark script I'm using: ```python import nibabel...
@neurolabusc @emanuele's code relies on NiBabel to read the TRK's header. Regarding speed, with PR #1000, it should be comparable.