Marc-Alexandre Côté

Results 117 comments of Marc-Alexandre Côté

Also, note that some games do have incomplete walkthrough (see issue #43). You can run this script to test the walkthroughs `python tools/test_games.py ./roms/*` ``` ./roms/905.z5 PASS ./roms/acorncourt.z5 PASS ./roms/advent.z5...

@IssamLaradji can we close this issue or is there something else we can help you with?

Regarding the segfault in Hollywood, see patch here: https://github.com/microsoft/jericho/pull/54/files#r797250250

Regarding the stack overflow in Loose, see patch: https://github.com/microsoft/jericho/pull/54/files#r799577224

Never happened to me. Interesting how we are finding bugs in 40+ years' games :)! The time-out is a good idea.

One can use the script > python tools/find_walkthrough.py to help figuring out new walkthroughs. Make sure you check the `--help` to see how you can leverage existing partial walkthroughs instead...

I agree callbacks need to be re-think a bit. Here's my rationale behind how it is structured at the moment. Regarding the specific event you mentioned (button pressed/released/dragged), you need...

> It might be related to default keybinds, ex: e is bound to exit the application and i for interaction. I think you are on the right track. A `vtkInteractorEventRecorder`...

I thought I had already replied to this issue. My bad :(. I'm all for splitting the huge `ui.py` into multiple files. I don't have a strong opinion about the...

I remember also observing that replaying events was slow but at some point (maybe I changed VTK version) it stopped being slow. I haven't used VTK recently, so maybe it...