Manish Goregaokar

Results 129 issues of Manish Goregaokar

The [RFCs repo has a lot of open issues](https://github.com/rust-lang/rfcs/issues), but these are mostly ignored by the teams. We should perhaps turn off issue-filing on the repo (maybe archiving existing issues...

M-triage
A-initiative

It might be worth caching the initial literal token so that spans work out correctly, and disallowing mutation.

`CollectArray where T: IsArray`, so you can do `foo.iter().map().frob().collect::().into_inner()`

We should have real tests with real asserts, the doctests don't actually verify the contents.

help wanted

Unfortunately I'm not able to come up with a minimal working example for this, but running `cargo check -p icu_datetime --examples` on https://github.com/unicode-org/icu4x (commit https://github.com/unicode-org/icu4x/commit/021a92e43a07f4178d97fd48ba509fb72164fa14 should be fine) ends up...

regression-from-stable-to-beta
A-const-eval
P-critical

https://github.com/Manishearth/HandWave/tree/androidstudio This code works on android studio

Firefox has a lot of HTML/JS tests under `tests/` that screw up the numbers. we should also perhaps exclude any `reftests/` `tests/`, or `mochitests/` folders

> Apart from lifetime extension, the temporary scope of an expression is the smallest scope that contains the expression and is for one of the following: > - The entire...

Caught by rustc CI The test fails when it tries to compare `[[""]]` with `[["\u{feff}"]]`. Presumably the BOM is being stripped somewhere. ```rust #[test] fn prop_cat_cols() { fn p(rows1: CsvData,...

weightedLength is pretty naïve in the set of unicode ranges it uses, relegating large swaths of languages/scripts to double weighting for no evident reason. ### Expected behavior Languages like Khmer...