Manish Goregaokar

The FFI coverage test has the following section of ignores: https://github.com/unicode-org/icu4x/blob/90db7c6a5ef3d64e969850c2655e8b9e45948c81/ffi/diplomat/ffi_coverage/src/main.rs#L140-L141 After 1.0, we should go through everything here and plan FFI for them, filing followups as needed.

ArithmeticDate::offset_date() doesn't handle wraparounds for months

3

The following code: https://github.com/unicode-org/icu4x/blob/fcdbad1be0b92752f18ba8c63d36352f2781d5ff/components/calendar/src/calendar_arithmetic.rs#L28-L33 will immediately panic if the month offset is negative and less than the number of current months, since there will be an arithmetic overflow. What this...

[css-shapes][css3-backgrounds] No explicit <position> serialization steps in background spec

11

https://drafts.csswg.org/css-shapes/#basic-shape-serialization https://drafts.csswg.org/css-backgrounds-3/#position The basic-shape spec mentions: > The values (including the defaults) in ellipse() and circle() serialize to their 2- and 4-value forms only, preferring the 2-value form when it...

Support having multiple FFI crates

5

I _believe_ that right now cbindgen can basically be used once per project to generate a single header file, with no dependencies. I'm working on ICU4X, which is a modular...

Ignore dev-dependencies

5

Currently `cbindgen` in parse-deps mode seems to include dev-dependencies and build-dependencies. It would be nice if that could be avoided. (In my case it means that we hit https://github.com/eqrion/cbindgen/issues/665 even...

I keep hitting limitations of parse-deps: It fails to compile some crates (https://github.com/eqrion/cbindgen/issues/665), pulls in dev dependencies (https://github.com/eqrion/cbindgen/issues/666), and also seems to pull in proc macro dependencies (and it has...

Was pointed out on HN, probably worth fixing. There are two other cases of unchecked string stuff where the string is built via ASCII bytes. I do think that we...

Deleted messages in chat

1

http://stackapps.com/questions/4465/bookmarklet-to-show-deleted-messages-in-chat Add a button to load deleted messages in chat for mods/room owners so that they can pick apart what happened.

Make r+ remove try bit

2

try followed by r+ doesn't work without a try- otherwise r? @barosl

Upstream changes from Servo

1

There's an unwanted commit hanging around, reverted it. Supersedes #133 r? @barosl