Manish Goregaokar

Results 134 issues of Manish Goregaokar

I was reviewing the lexical-write-integer crate and I discovered a bunch of things that could be improved wrt safety. The main issue was the one already filed as https://github.com/Alexhuszagh/rust-lexical/issues/95. That's...

This crate reexports functionality from various subcrates. Unfortunately, it also has some metafeatures that attempt to enable functionality across these crates. Due to how Cargo feature dependencies work, enabling a...

WIP: Still need to replace in ks.xml; will try using Eclipse This normalizes YEH WITH TAIL (an incorrect Pashto letter) to KASHMIRI YEH. See L2/23-241. CLDR-16595 - [x] This PR...

This currently compiles (on stable and nightly). Till 1.25, it would trigger a [lint](https://github.com/rust-lang/rust/issues/39216) because it has inference default to `()` instead of throwing an error. ```rust fn main() {}...

T-compiler
regression-from-stable-to-stable
A-inference
C-bug

See https://github.com/rust-fuzz/arbitrary/issues/149 It's easy to accidentally write code like this: ```rust #[derive(Arbitrary)] enum Foo { A(u8), #[arbitrary(with = |_| Bar::new())] B(Bar). } ``` Here, the attribute will not have any...

enhancement
help wanted

https://github.com/immersive-web/webxr-hand-input/pull/121, take 2 (reverted in #122) It's unclear to me if we shoudl require "generic-hand" at all times or allow "generic-hand-select" input methods to omit "generic-hand" (thoughts @cabanier?) Fixes immersive-web/webxr#1358...

Hi! I love this plugin, thank you so much for making it! Unfortunately, for the last year, Amazon's "Send to Kindle" functionality has been [incorrectly naming files it sends to...

https://github.com/jltsiren/gbwt-rs/blob/cd78e7f8f529866ee1f260db6261817f840ef5cb/src/bwt.rs#L360C19-L360C33 While unsafe reviewing gbz-base I noticed that `Record::from_raw_parts()` has nontrivial safety invariants. However it's not clear to me if `Record` actually _uses_ those invariants for safety-critical things, or if...

- [x] I have searched open and closed issues for duplicates - [x] I am submitting a bug report for existing functionality that does not work as intended - [x]...

Docs.rs currently supports metadata of this format: ```rust [package.metadata.docs.rs] all-features = true ``` Sometimes crates have "private" features; which shouldn't be documented on docs.rs. It _is_ possible to use `doc(hidden)`...

E-medium
A-builds
C-enhancement