Manish Goregaokar

Results 134 issues of Manish Goregaokar

force still should work on travis-only repos. This causes it to crash early. r? @barosl

``` File "/home/servo/homu/_venv/bin/bottle.py", line 862, in _handle return route.call(**args) File "/home/servo/homu/_venv/bin/bottle.py", line 1732, in wrapper rv = callback(*a, **ka) File "/home/servo/homu/homu/server.py", line 103, in callback repo_cfg = g.repo_cfgs[repo_label] ```

See https://github.com/servo/servo/pull/6198 for example

Following accounts on a separate instance from yours is a multi step process and can be slow. However, it's easy when you open that account on your own instance, e.g....

`[email protected]` is as of yesterday broken on Rust nightly, even if you do not choose to opt in to its nightly features, because it autoenables features in build.rs. See https://github.com/tkaitchuck/aHash/issues/200....

bug
priority-medium

https://github.com/hyperium/hyper/blob/1d4ff3597b8e76818c8553dbfa4234cf4208c958/src/proto/h2/mod.rs#L389C8-L397 This isn't sound. `Neutered` is: ```rust #[repr(transparent)] struct Neutered { _inner: B, impossible: Impossible, } enum Impossible {} ``` Firstly, it's unclear what guarantees `repr(transparent)` confers here, `impossible` does...

C-bug

https://github.com/hyperium/hyper/blob/1d4ff3597b8e76818c8553dbfa4234cf4208c958/src/ffi/task.rs#L504 This comment is incorrect, `repr(Rust)` provides no such guarantees. (Also we probably should make most of these FFI types `repr(C)`))

Fixes #102 This would be a breaking change. The nonbreaking way to do this is to doc(hidden) and deprecate the old API, but I'll let y'all figure out how to...

BytesIter seems to have a safety invariant: https://github.com/Alexhuszagh/rust-lexical/blob/09c686b075096d48155cfb32265068f962afc56c/lexical-util/src/iterator.rs#L20-L22C1 This means the trait should be private or unsafe. I don't have time to craft a testcase, but it would mostly be...

bug

## Description `Bytes::read()` only requires that `V` be of the right length, and imposes no validity requirements. This is trivially usable to create unsoundness. ## Test case ```rust use lexical_util::iterator::Bytes;...

bug