Manish Goregaokar

Results 134 issues of Manish Goregaokar

This happened with `/html/dom/idlharness.https.html?exclude=(Document|Window|HTML.*)` but I strongly suspect it's not about that specific test. ``` ▶ Unexpected subtest result in /html/dom/idlharness.https.html?exclude=(Document|Window|HTML.*): │ FAIL [expected PASS] idl_test setup └ → promise_test:...

I-intermittent

Rather useful when looking up characters here

Would be nice if this could work well on a phone, perhaps showing the textbox as part of the lookup/options/etc tabs, with textbox by default; and showing the code points...

With a compile-time hashmap, having a cryptographically secure hash is less important since there are no pathological cases to worry about -- everything is done at compile time. IIRC SipHasher...

C-enhancement

Caught during unsafe review https://github.com/tormol/uds/blob/a5968947e08cc092b417f30f12bd3d9cf3b4c981/src/addr.rs#L647-L654 Some platforms, including FreeBSD, require a null terminator here, which we are sometimes stripping e.g. [FreeBSD](https://man.freebsd.org/cgi/man.cgi?query=unix&sektion=4): > The sun_path field must be terminated by a...

Related to https://github.com/servo/servo/issues/9555, part of the cause (fixing this is not a complete solution). https://github.com/servo/servo/blob/b97ffffb48080a0b4769f8609a27a68145042945/components/gfx/font_cache_thread.rs#L154 We're sending an `Arc` over IPC here, where `FontTemplateData` is a largish bucket of bytes....

A-platform/fonts
I-wrong
I-perf-slow
I-safety
A-gfx/uncategorized

Part of https://github.com/unicode-org/icu4x/issues/3413 Currently DateTimeSymbols data contains data for every length of symbol data, regardless of which is requested. We shoudl slice it down into MonthSymbols (which can be long/short/medium/full),...

C-datetime

DateSymbols is giant and has a lot of things inside it, only a fraction of which actually gets used once a formatter has been constructed. We should split this type...

C-datetime
S-large

Split out of https://github.com/unicode-org/icu4x/issues/3865 https://github.com/unicode-org/icu4x/pull/4228 adds support for numeric overrides in patterns. We need to teach DateTimeFormat to apply these.

C-datetime

This is probably a 2.0 change (https://github.com/unicode-org/icu4x/issues/2856) The properties code uses a lot of free functions for loading property maps and such, rather than using constructors on [`CodePointSetData`](https://unicode-org.github.io/icu4x/docs/icu_properties/sets/struct.CodePointSetData.html) and [`CodePointMapData`](https://unicode-org.github.io/icu4x/docs/icu_properties/maps/struct.CodePointMapData.html)...

discuss
discuss-priority
discuss-triaged