Jongsun Suh

Results 79 issues of Jongsun Suh

## References - Follow-up from https://github.com/MetaMask/metamask-mobile/pull/10011 ## Motivation The `ComposableController` API is currently not working as expected in downstream consumers (mobile). ## Explanation - The `BaseControllerV1Instance` type needs to be...

bug
team-wallet-framework

## Explanation Some of our classes that were previously labeled as controllers have empty state, making them [non-controllers](https://github.com/MetaMask/decisions/blob/main/decisions/core/0001-messaging-non-controllers.md?rgh-link-date=2024-06-21T15%3A20%3A49Z). As part of Wallet Framework team's Q2 2024 OKRs (O3KR1), we're currently...

team-wallet-framework

```ts '@typescript-eslint/prefer-enum-initializers': 'error', '@typescript-eslint/prefer-nullish-coalescing': 'warn', '@typescript-eslint/prefer-optional-chain': 'warn', '@typescript-eslint/prefer-reduce-type-parameter': 'warn', ``` In future PRs, enabling the 'prefer' rules should remove the need for some style guide entries (TODO: link entries)

team-wallet-framework

```ts '@typescript-eslint/no-unnecessary-type-assertion': 'error', ``` Should be helpful for minimizing [redundant or silent-failure assertions](https://github.com/MetaMask/contributor-docs/blob/main/docs/typescript.md?rgh-link-date=2024-06-10T17%3A10%3A48Z#example-3675ab71-bcd6-4325-ac18-8ba4dd8ec03c).

team-wallet-framework

As part of the Wallet Framework Team's Q2 2024 OKRs (O3/KR4), we are upgrading all core packages to use TypeScript v5.4, with the goal of eventually upgrading to the latest...

team-wallet-framework

As part of the Wallet Framework Team's Q2 2024 OKRs (O3/KR4), we are upgrading all core packages to use TypeScript v5.3, with the goal of eventually upgrading to the latest...

team-wallet-framework

As part of the Wallet Framework Team's Q2 2024 OKRs (O3/KR4), we are upgrading all core packages to use TypeScript v5.2, with the goal of eventually upgrading to the latest...

team-wallet-framework

As part of the Wallet Framework Team's OKR (Q2 2024 O3KR4) for upgrading TypeScript to v5.0+ in the core monorepo, we are updating dependencies of the core repo so that...

team-wallet-framework

## **Description** - Major version bump for `@metamask/utils`. - Causes large number of type error regressions which are resolved here: https://github.com/MetaMask/metamask-extension/pull/26143 - Storybook deps bumped to avoid mixed usage of...

team-wallet-framework
needs-dev-review