Jongsun Suh

Results 79 issues of Jongsun Suh

## **Description** Cherry-pick of #26143 for ~v12.1.0-rc~ v12.1.1-rc. This is a very different PR from the original, as I had to remove diffs to a significant amount of code that...

DO-NOT-MERGE
team-wallet-framework
INVALID-PR-TEMPLATE

## **Description** This commit updates the `@metamask/composable-controller` to the upcoming release `8.0.0`. This involves fixing bugs outlined in https://github.com/MetaMask/metamask-mobile/issues/10073, and applying the major changes to the `ComposableController` API that has...

No QA Needed
team-wallet-framework

`isSafeDynamicKey` should be able to handle all `PropertyKey` types.

team-wallet-framework

## **Description** The current ruby install instructions in the "Environment Setup" readme are vague, and may cause `gem` to be run with the system root installation. ![Screenshot 2024-10-09 at 9...

No QA Needed
needs-dev-review
area-documentation
team-wallet-framework
No E2E Smoke Needed

## **Description** ```md ### Changed - **BREAKING:** Bump `@metamask/ppom-validator` from `0.32.0` to `0.34.0` ([#11114](https://github.com/MetaMask/metamask-mobile/pull/11114)) ``` To fully align the dependencies, a new release of `ppom-validator` will need to be released...

team-wallet-framework
Run Smoke E2E

### What is this about? This involves removing or replacing the patch for `7.0.2`. ### Scenario _No response_ ### Design _No response_ ### Technical Details _No response_ ### Threat Modeling...

team-wallet-framework

## **Description** ```md ### Changed - Bump `@metamask/approval-controller` from `^7.0.1` to `^7.0.3` ([#11116](https://github.com/MetaMask/metamask-mobile/pull/11116)) ``` ## **Related issues** - Closes https://github.com/MetaMask/metamask-mobile/issues/11178 ## **Manual testing steps** 1. Go to this page... 2....

team-wallet-framework
Run Smoke E2E

## Motivation Listeners in typical event systems like `EventEmitter` only trigger if they existed when the event was emitted. However, the messenger event pubsub system in our `ControllerMessenger` class does...

bug
team-wallet-framework

- The config format that we currently use is deprecated starting in ESLint v9: https://eslint.org/docs/latest/use/configure/configuration-files-deprecated - The `@metamask/eslint-config` monorepo has migrated to the new flat config format, which makes it...

team-wallet-framework

## Explanation ## References - Closes https://github.com/MetaMask/core/issues/4745 ## Changelog ### `@metamask/package-a` - ****: Your change here - ****: Your change here ### `@metamask/package-b` - ****: Your change here - ****:...

DO-NOT-MERGE
team-wallet-framework