Jongsun Suh

Bump TypeScript to `^5.0.4` and set `module`, `moduleResolution` to `NodeNext`

4

## Explanation As part of the Wallet Framework Team's OKRs (Q2 2024 O3KR4), we are upgrading TypeScript to v5.0+ for all packages in the core monorepo. ## References - Closes...

## Explanation The following controllers need to be updated so that `@metamask/base-controller` is bumped to 4.0.0, and references to `BaseController` are fixed to `BaseControllerV1` while instances of `BaseControllerV2` are fixed...

Fix the following CodeQL security alerts: - https://github.com/MetaMask/core/security/code-scanning/2 - https://github.com/MetaMask/core/security/code-scanning/3 ### Approach 1 Replace the flagged property assignments by returning an updated object in the enclosing `this.update()` call, or mutating...

Fix the following CodeQL security alerts: - https://github.com/MetaMask/core/security/code-scanning/4 - https://github.com/MetaMask/core/security/code-scanning/5 ### Approach 1 Replace the flagged property assignments by returning an updated object in the enclosing `this.update()` call, or using...

[json-rpc-engine] Improve handling for unexpected middleware error types, align error types to use `JsonRpcEngineCallbackError`

1

## Motivation Currently, `JsonRpcEngine` handles non-JSON-RPC errors thrown from middleware by passing them into `end` callbacks without validation or serialization. Fixing this is necessary to take full advantage of the...

[composable-controller] Make class and messenger generic upon child controllers

3

## Explanation Currently, the allow lists of `ComposableControllerMessenger` are set to `string`, which is too permissive. Each `ComposableController` instance needs typing and allow lists that are specific to its set...

## Explanation Records an initial approach discussed by the team during refinement. This ticket is available for anyone to take over and build on top of this or discard as...

The `Token` type defined in the `TokenRatesController` has a `balanceError` property, which is typed as `unknown`. This property is assigned an error value in the `TokensBalancesController` `updateBalances` method. `TokensController` uses...

There are hundreds of instances of `any` type usage and `as` assertions spread throughout the [metamask-extension](https://github.com/MetaMask/metamask-extension), [core repo](https://github.com/MetaMask/core), and other MetaMask libraries. To uphold coding standards and unlock type-safe feature...

## Motivation - Middleware functions in `eth-json-rpc-middleware`, `eth-json-rpc-engine`, `eth-json-rpc-infura` are ["return type-only" generics](https://google.github.io/styleguide/tsguide.html#return-type-only-generics) with implicit generic parameters. This is a discouraged pattern. - Redefining the functions to expose the generic...