Jongsun Suh
Jongsun Suh
## Requirements - Should not inherit from `BaseControllerV1` or `BaseController`. - Should not use the `Controller` suffix in its name. - Types for `ControllerState`, `ControllerGetStateAction`, `ControllerStateChangeEvent` should not be defined...
## Requirements - Should not inherit from `BaseControllerV1` or `BaseController`. - Should not use the `Controller` suffix in its name. - Types for `ControllerState`, `ControllerGetStateAction`, `ControllerStateChangeEvent` should not be defined...
## Explanation As part of the Wallet Framework Team's Q2 2024 OKRs (O3KR1: 100% completion of all core controllers to BaseControllerV2), the `AssetsContractController` needs to be converted to a V2...
## Explanation ## References - Closes https://github.com/MetaMask/core/issues/4448 - Closes https://github.com/MetaMask/core/issues/4444 - Fixes https://github.com/MetaMask/metamask-mobile/issues/10073 - See https://github.com/MetaMask/metamask-mobile/pull/10011 ## Changelog ```md ``` ## Checklist - [ ] I've updated the test suite...
## Problem `BaseControllerV2` and its subclass controllers currently accept messengers as constructor options even if they are defined with incomplete or empty action/event allowlists. Type errors are raised when the...
## Explanation Some of our classes that were previously labeled as controllers have empty state, making them [non-controllers](https://github.com/MetaMask/decisions/blob/main/decisions/core/0001-messaging-non-controllers.md). As part of Wallet Framework team's Q2 2024 OKRs (O3KR1), we're currently...
## Current controller classes with empty state - [x] #4072 - [x] #4433 - [ ] #4434 - [ ] #4435 ## Requirements - Should not inherit from `BaseControllerV1` or...
As part of the Wallet Framework Team's Q2 2024 OKRs (O3/KR4), we are upgrading all core packages to use TypeScript v5.1, with the goal of eventually upgrading to the latest...
In the following, `contract.balances` and `result` are implicitly typed as `any`, because the `Contract` class doesn't have a `balances` method. ```ts import { Contract } from '@ethersproject/contracts'; ... async getBalancesInSingleCall(...
## Explanation ## References ## Changelog ### `@metamask/package-a` - ****: Your change here - ****: Your change here ### `@metamask/package-b` - ****: Your change here - ****: Your change here...