Jongsun Suh

Results 79 issues of Jongsun Suh

- [ ] CamelCase - [ ] CobolCase - [ ] ConstantCase - [ ] KebabCase - [ ] PascalCase - [ ] SnakeCase

enhancement
good first issue

## Explanation ## References - Closes #4271 ## Changelog ### `@metamask/package-a` - ****: Your change here - ****: Your change here ### `@metamask/package-b` - ****: Your change here - ****:...

team-shared-libraries

## Requirements When initializing a `ComposableController` class, given a `ComposableControllerState` type: 1. A type error should be raised if the list of child controllers specified in the `controllers` array constructor...

bug
team-wallet-framework

### What is this about? ## Explanation `ComposableController` usage in the mobile Engine is currently broken in two ways. 1. The first argument of the `ComposableController`'s constructor has a type...

type-bug
Sev2-normal
team-wallet-framework

## **Description** - Applies `ComposableController` API changes introduced to the controller in the following series of PRs: - https://github.com/MetaMask/core/pull/3590 (`v5.0.0`) - https://github.com/MetaMask/core/pull/3904 (`v6.0.0`) - https://github.com/MetaMask/core/pull/3964 (`v6.0.0`) - https://github.com/MetaMask/core/pull/3952 (`v6.0.2`) -...

team-wallet-framework

## Motivation As part of Shared Libraries Q2 2024 OKRs (O3/KR5), we will be upgrading Jest to v29 in all core libraries. We will also remove `@types/jest` entirely and migrate...

team-wallet-framework

Some of our classes that were previously labeled as controllers have empty state, making them [non-controllers](https://github.com/MetaMask/decisions/blob/main/decisions/core/0001-messaging-non-controllers.md?rgh-link-date=2024-06-21T15%3A43%3A15Z). As part of Wallet Framework team's Q3 2024 OKRs (O1KR1), we're currently in the...

team-wallet-framework

TODO: list affected controllers (`TokenDetectionController`, ...)

team-wallet-framework

## Problem Constructor controllers currently raise a type error when instantiated with a messenger that was defined with an incomplete list of internal actions/events, but fail to raise that error...

bug
team-wallet-framework

## Requirements - Should not inherit from `BaseControllerV1` or `BaseController`. - Should not use the `Controller` suffix in its name. - Types for `ControllerState`, `ControllerGetStateAction`, `ControllerStateChangeEvent` should not be defined...

team-wallet-framework