Update `BaseController` references in controllers that are not located in core

[MajorLift]

Explanation

The following controllers need to be updated so that @metamask/base-controller is bumped to 4.0.0, and references to BaseController are fixed to BaseControllerV1 while instances of BaseControllerV2 are fixed to BaseController.

• metamask-extension:
  • [ ] DecryptMessageController
  • [ ] EncryptionPublicKeyController
  • [ ] ComposableObservableStore.test.js
• [x] metamask-mobile:
• snaps:
  • [ ] SnapController
  • [ ] JsonSnapsRegistry
  • [ ] CronjobController
• ppom-validator:
  • [ ] PPOMController
• smart-transactions-controller:
  • [ ] SmartTransactionsController
• swaps-controller:
  • [ ] SwapsController

References

• Follow-up from https://github.com/MetaMask/core/pull/2078